Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deactivated merger action #141

Closed
wants to merge 1 commit into from
Closed

Drop deactivated merger action #141

wants to merge 1 commit into from

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Jul 7, 2024

Since we moved the repository to this organization, the auto merger is failing due to different permissions. #139, #140

failed to create review: GraphQL: GitHub Actions is not permitted to approve pull requests. (addPullRequestReview)

So, I think just removing the action will be reasonable, considering the strict organizational policy.

Appendix: Allow some permissions to enable auto merger again
gh repo edit --enable-auto-merge

gh api \
  --method PUT \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  '/repos/{owner}/{repo}/actions/permissions/workflow' \
  -F can_approve_pull_request_reviews=true

ref: https://github.com/orgs/mise-plugins/discussions/13

@kachick
Copy link
Contributor Author

kachick commented Aug 23, 2024

I still think same changes should be applied in https://github.com/mise-plugins/asdf-cargo-make and https://github.com/mise-plugins/asdf-zigmod

cc: @mise-plugins

@kachick kachick closed this Aug 23, 2024
@kachick kachick deleted the drop-inactive-action branch August 23, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant