Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arduino tmx #42

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Fix arduino tmx #42

merged 4 commits into from
Jan 10, 2024

Conversation

ArendJan
Copy link
Contributor

@ArendJan ArendJan commented Jan 8, 2024

Fixes when using a Arduino

  • oled: add timeout when writing to i2c to not overload the serial port
  • Fix asyncio loop passing to telemetrix library to share the same loop. Without this, no serial data is ever read

Should still work with rp2040, need to test tomorrow

@ArendJan ArendJan added the bug Something isn't working label Jan 8, 2024
@ArendJan ArendJan added this to the 0.1 milestone Jan 8, 2024
@ArendJan ArendJan requested a review from mklomp January 8, 2024 15:40
@ArendJan ArendJan self-assigned this Jan 8, 2024
mklomp
mklomp approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@mklomp mklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some minor questions, looks good.

mirte_telemetrix/scripts/ROS_telemetrix_aio_api.py Show resolved Hide resolved
mirte_telemetrix/scripts/ROS_telemetrix_aio_api.py Outdated Show resolved Hide resolved
mirte_telemetrix/scripts/ROS_telemetrix_aio_api.py Outdated Show resolved Hide resolved
@ArendJan ArendJan merged commit 352e637 into main Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mklomp mklomp mklomp approved these changes

Assignees

@ArendJan ArendJan

Labels
bug Something isn't working
Projects
Mirte
Status: ✅ Done
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ArendJan @mklomp