Fix oled by using thread safe run_coroutine_threadsafe #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ros service is started on a different thread than the asyncio loop.
When using the normal loop.run_until_complete() function, both threads join in and there might be race conditions and the oled function might break faster.
With run_corotine_threadsafe, the function is started on the asyncio thread, without the ros service thread joining in and 'helping'.
Tested it with this code:
Worked for at least 10 minutes at 5Hz.