Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix digitalread not always sending a message from setup #12

Merged

Conversation

ArendJan
Copy link

@ArendJan ArendJan commented Oct 9, 2023

Fixes mirte-robot/mirte-ros-packages#25 by setting last_value to something that digitalread cannot be, such that it will always send a message as it checks for changes before sending

@ArendJan ArendJan force-pushed the 25-mirteget_pin_value-never-returning branch from 030a5ae to 2c460b5 Compare October 9, 2023 14:28
@ArendJan ArendJan requested a review from mklomp October 9, 2023 14:29
Copy link

@mklomp mklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, looks good ;)

@mklomp mklomp merged commit 8485e82 into mirte-robot:master Oct 10, 2023
@ArendJan ArendJan deleted the 25-mirteget_pin_value-never-returning branch October 11, 2023 08:13
ArendJan added a commit that referenced this pull request Oct 11, 2023
Pull request #13 probably removed the change from #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/mirte/get_pin_value never returning
2 participants