Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 10 #22

Closed
rzr opened this issue Apr 5, 2019 · 7 comments
Closed

Support Node 10 #22

rzr opened this issue Apr 5, 2019 · 7 comments

Comments

@rzr
Copy link
Collaborator

rzr commented Apr 5, 2019 •
edited
Loading

It looks like i2c module is no more maintained maybe we can use an other i2c implementation ?

Relate-to: kelly/node-i2c#90
Relate-to: kelly/node-i2c#91
rzr added a commit to CrossStream/bh1750 that referenced this issue Jul 15, 2019
@rzr
npm: Support node-10 with abandonware i2c
f5b02f1 
Bug: miroRucka#22
Change-Id: Ic77764ba2a71119394988cb0035bbeb521c65b1a
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr rzr mentioned this issue Jul 15, 2019
Merged
rzr added a commit to CrossStream/bh1750 that referenced this issue Jul 15, 2019
@rzr
npm: Support node-10 with abandonware i2c
a29e111 
Bug: miroRucka#22
Forewarded: miroRucka#24
Change-Id: Ic77764ba2a71119394988cb0035bbeb521c65b1a
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@shidevil
Copy link

shidevil commented Dec 14, 2019 •
edited
Loading

@rzr Will it support node 12? with abandonware i2c.

@rzr
Copy link
Collaborator Author

rzr commented Dec 14, 2019 •
edited
Loading

I think so, I would make sense to merge it , then I will rebase and check

meanwhile use the abandonware version:

https://github.com/abandonware/bh1750

May I also suggest to try:
https://github.com/rzr/generic-sensors-lite

@shidevil
Copy link

Sadly i tried abandonware i2c and it doesn't compile with node 12. i2c failed to compile.

@rzr
Copy link
Collaborator Author

rzr commented Dec 15, 2019

Then please file bug in
https://github.com/kelly/node-i2c/issues
or share patches to:
https://github.com/abandonware/node-i2c

@shidevil
Copy link

@rzr Will file a bug there. Thanks

@rzr
Copy link
Collaborator Author

rzr commented Dec 15, 2019

Relate-to: kelly/node-i2c#98

@rzr
Copy link
Collaborator Author

rzr commented Feb 25, 2020

I think this issue can be solved master branch has my changes in

Meanwhile it is released you can use:

https://www.npmjs.com/package/@abandonware/bh1750/v/0.0.7-2

@rzr rzr closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rzr @shidevil