Refresh GitHub actions CI workflow based on r-lib/actions v2 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This should not be an issue anymore on `r-devel`, see #26 and r-lib/actions#339 This reverts commit 3a07928.
* This should not be an issue anymore on `r-devel`, see #26 and r-lib/actions#339 This reverts commit cd896d1.
…` examples * Closes #26. * Latest setup got via `usethis::use_github_action("check-standard", save_as = "ci.yaml")`, using development `usethis` version (to support relying on the default branch, now `v2-branch`). * `covr` installed via pak, so it is cached alongside the other dependencies. (Not done as part of `setup-r-dependencies` for all jobs, since it is only used in conditional steps.) * Drop fixing macOS symlinks (fixed in `v2`), but keep the 5 minutes timeout for setup-r (#24), since r-lib/actions#435 isn't fully addressed.
* As in the `check-standard-example`. * The Ubuntu version had to be fixed to specify the specific RSPM URL explicitly, which is now internally handled in a dynamic way in `r-lib/setup-r@v2` with `use-public-rspm: true`.
riccardoporreca
force-pushed
the
feature/26-r-lib-actions-v2
branch
from
93c4d47
to
8f9b004
Compare
Chargothrond
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Looks good to me. I am familiar with most of the updates and which steps can be removed now thanks to the v2 r-lib/actions. Also, the updates to the windows and mac jobs are explained in #26.
I assume valgrind being skipped is expected?
|
Thanks for the review @Chargothrond
It is in fact run for as part of the PR checks (skipped on the branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26 and individual commits for details