Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve map legend to include negative values #59

Closed
fvitalini opened this issue Apr 3, 2020 · 1 comment
Closed

improve map legend to include negative values #59

fvitalini opened this issue Apr 3, 2020 · 1 comment
Assignees
@StefGehring
Labels
enhancement New feature or request todo Tickets to be done

Comments

@fvitalini
Copy link
Contributor

after the implementation of #56 we have now new active as an option for the map. This can have negative values, currently outside of our legend range. Fix this by adding a color for negative values.
@fvitalini fvitalini added the enhancement New feature or request label Apr 3, 2020
@GuidoMaggio GuidoMaggio added the todo Tickets to be done label Apr 18, 2020
@fvitalini
Copy link
Contributor Author

Set different color for NA for the time being
https://github.com/miraisolutions/Covid19/blob/master/R/mod_map.R
line 132 gray instead of white

StefGehring added a commit that referenced this issue May 25, 2020
@StefGehring
sg set different color -grey for NA in new active mod_map.R (#59)
b444e69
StefGehring added a commit that referenced this issue May 25, 2020
@StefGehring
sg update NEWS set different color -grey for NA in new active mod_map…
0f4dbe8 
….R (#59)
@StefGehring StefGehring mentioned this issue May 25, 2020
Merged
GuidoMaggio added a commit that referenced this issue May 27, 2020
@StefGehring @GuidoMaggio @riccardoporreca
Feature/59 negative in map (#85)
b6ddb47 
* sg set different color -grey for NA in new active mod_map.R (#59)

* sg update NEWS set different color -grey for NA in new active mod_map.R (#59)

* Adjusted text

* removed failing test, not used

* added, forgotten in othr issues

* Uninstall cached packages

installed with different R version

* Missing quotes

* Temporarily delete cached library

As it was produced with R 4.x

* Reverted first uninstall attempt

* Revert "Temporarily delete cached library"

This reverts commit 1be87e7.

Co-authored-by: Guido Maggio <guido.maggio@mirai-solutions.com>
Co-authored-by: Guido Maggio <GuidoMaggio@users.noreply.github.com>
Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>
@StefGehring StefGehring mentioned this issue May 28, 2020
Closed
StefGehring added a commit that referenced this issue May 28, 2020
@StefGehring
sg prep for release 1.1.7
0c6ed22 
- closes (#59)
- closes (#79)
- closes (#80)
- closes (#67)
- closes (#69)
- closes (#74)
- closes (#66)
- closes (#68)
- closes (#81)
- closes (#83)
@StefGehring StefGehring mentioned this issue May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefGehring StefGehring

Labels
enhancement New feature or request todo Tickets to be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fvitalini @GuidoMaggio @StefGehring