T11699: Use jobs and hooks to automate checking that a domain is pointed #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th notpointed i18n pending
redbluegreenhat
commented
Jan 21, 2024
SQL will need regenerating
redbluegreenhat
changed the title
redbluegreenhat
changed the title
redbluegreenhat
changed the title
redbluegreenhat
changed the title
redbluegreenhat
commented
Jan 27, 2024
| $requestSslManager->fromID( $this->params['requestID'] ); | ||
| $isPointed = false; | ||
| $hookContainer = $mwServices->getHookContainer(); | ||
| $hookContainer->run( 'RequestSSLDomainCheck', [&$requestSslManager, &$isPointed] ); |
There was a problem hiding this comment.
Regarding hooks, I have to register this hook on extension.json before usage, I don't think this will even work.
CreateWiki registers them in HookHandler like this. https://github.com/miraheze/CreateWiki/blob/3f8003973176c2225894dc39d73f1fe3a8e8275e/extension.json#L113
https://github.com/miraheze/CreateWiki/tree/master/includes/Hooks
|
Closing. I'm going to start from zero on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.