Use Gc.quick_stat for faster stats #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Gc.stat` spends time exploring the heap to collect more statistics, which we didn't report anyway. For large heaps, `Gc.stat` can be a problem: I see collection times of around 2s with a 16GB heap.
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Mar 3, 2020
CHANGES: - switch float representation to OCaml's default `"%f"` (mirage/prometheus#22, @toots) - use `Gc.quick_stat` for faster stats (mirage/prometheus#25, @talex5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gc.statspends time exploring the heap to collect more statistics, which we didn't report anyway.For large heaps,
Gc.statcan be a problem: I see collection times of around 2s with a 16GB heap.