Don't ignore 'junk' #132
Merged
Don't ignore 'junk' #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, the unit-tests appear to be testing small sizes. How did that pass before? https://github.com/mirage/ocaml-vchan/blob/master/lib_test/test.ml#L37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not always junk! If sufficiently small buffers are needed they can fit in the ring page (
Within_shared_page). The Linux implementation doesn't seem to take advantage of this in practice, but we do in MirageOS(!) https://github.com/mirage/ocaml-vchan/blob/master/lib/endpoint.ml#L356I stumbled on this while trying to make qrexec calls between MirageOS unikernels in QubesOS.