Update to new OS.Xen grant API #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yomimono
reviewed
Mar 22, 2019
- `Gntref.t` is now abstract - update sexp converters to use `to_int32`/`from_int32`. - `gntshr_interface_open` is no longer needed. - Instead of wrapping the underlying share type with our own (that just converts the grant refs to `int32`), use the underlying object directly. This is needed because `Export.t` is now abstract and we so cannot create them ourselves, but it seems simpler this way too. - The new `Export.unshare` requires us to say whether to release the grant refs too. It looks like we should have been doing this, so I passed `true` here, although the original code didn't. The old Gnt API was a bit vague about this; it looks like it released the refs on Unix but not on Xen.
yomimono
approved these changes
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see mirage/mirage-xen#9)
Gntref.tis now abstract - update sexp converters to useto_int32/from_int32.gntshr_interface_openis no longer needed.int32), use the underlying object directly. This is needed becauseExport.tis now abstract and we so cannot create them ourselves, but it seems simpler this way too.Export.unsharerequires us to say whether to release the grant refs too. It looks like we should have been doing this, so I passedtruehere, although the original code didn't. The old Gnt API was a bit vague about this; it looks like it released the refs on Unix but not on Xen.Note that no version of mirage-xen with the new API has been released yet, so we might want to wait for that before merging.
/cc @yomimono