Enlarge internal buffers to be able to parse large tree objects #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI error are unrelated, ready to merge. |
|
You can rebase on top of #390 if you want to see the actual errors from CI. |
Otherwise, this masks genuine errors from the CI.
Error was:
21 | module R = Resolver_mirage.Make_with_stack (Mirage_crypto_rng) (Mclock) (Tcpip_stack_socket)
^^^^^^
Error: Signature mismatch:
Modules do not match:
sig
val elapsed_ns : unit -> int64
val period_ns : unit -> int64 option
end
is not included in
Mirage_time.S
The value `sleep_ns' is required but not provided
File "src/mirage_time.ml", line 28, characters 2-35:
Expected declaration
This was referenced Jun 8, 2020
Closed
Closed
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jun 30, 2020
CHANGES: - Move to `encoder.0.5` (mirage/ocaml-git#393, @dinosaure) - Move to `angstrom.0.14.0` (mirage/ocaml-git#384, @sternenseemann) - Add missing Time argument to `Resolver_mirage.Make_with_stack` (mirage/ocaml-git#389, @talex5) - Fix .ocamlformat file (mirage/ocaml-git#389, @talex5) - Enlarge internal buffer used to parse Git object (mirage/ocaml-git#389, @dinosaure) - Update README.md (mirage/ocaml-git#383, @dinosaure) - Use `mirage-crypto` instead `nocrypto` (mirage/ocaml-git#382, @hannesm) - Add constraint on `dune` package (@kit-ty-kate)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jan 8, 2021
CHANGES: - Move to `encoder.0.5` (mirage/ocaml-git#393, @dinosaure) - Move to `angstrom.0.14.0` (mirage/ocaml-git#384, @sternenseemann) - Add missing Time argument to `Resolver_mirage.Make_with_stack` (mirage/ocaml-git#389, @talex5) - Fix .ocamlformat file (mirage/ocaml-git#389, @talex5) - Enlarge internal buffer used to parse Git object (mirage/ocaml-git#389, @dinosaure) - Update README.md (mirage/ocaml-git#383, @dinosaure) - Use `mirage-crypto` instead `nocrypto` (mirage/ocaml-git#382, @hannesm) - Add constraint on `dune` package (@kit-ty-kate)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jan 8, 2021
CHANGES: - Move to `encoder.0.5` (mirage/ocaml-git#393, @dinosaure) - Move to `angstrom.0.14.0` (mirage/ocaml-git#384, @sternenseemann) - Add missing Time argument to `Resolver_mirage.Make_with_stack` (mirage/ocaml-git#389, @talex5) - Fix .ocamlformat file (mirage/ocaml-git#389, @talex5) - Enlarge internal buffer used to parse Git object (mirage/ocaml-git#389, @dinosaure) - Update README.md (mirage/ocaml-git#383, @dinosaure) - Use `mirage-crypto` instead `nocrypto` (mirage/ocaml-git#382, @hannesm) - Add constraint on `dune` package (@kit-ty-kate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wants to enlarge internal buffers to be able to decode large tree object as noticed here: mirage/irmin#1001. The PR deletes an old french comment about a possible bug because we used
set_len/add_len(see #345).It's a small fix (and highlight a larger problem) but something better will appear soon (so much teasing).