fix inconsistent sector size between block and fs #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`let page = alloc 4096 in` seems to force read 4KiB but its unit should be FAT sector size. This fixes "mirage-skeleton/device-usage/kv_ro", configured with hvt && --kv_ro=fat. Signed-off-by: Hiroshi Doyu <hiroshi.doyu@ericsson.com>
ehirdoy
changed the title
ehirdoy
pushed a commit
to ehirdoy/light_actor
that referenced
this pull request
Apr 12, 2019
Here's a branch of this: https://github.com/ehirdoy/light_actor/tree/bi-tcp%2Bfrag%2Bstorage2 This requires some patch: mirage/ocaml-fat#81 from ocaml-fat $ cd light_actor/test/mirage $ wget http://yann.lecun.com/exdb/mnist/train-images-idx3-ubyte.gz $ wget http://yann.lecun.com/exdb/mnist/train-labels-idx1-ubyte.gz $ ./split-mnist-data $ mirage clean ; mirage configure -t unix --kv_ro=direct && make depend && make On 3 terminals repectively run: $ ./lwae $ ./lwae --uuid=w0 $ ./lwae --uuid=w1 --port=6001 And $ mirage clean ; mirage configure -t hvt --kv_ro=fat && make depend && make Signed-off-by: Hiroshi Doyu <hiroshi.doyu@ericsson.com>
ehirdoy
pushed a commit
to ehirdoy/light_actor
that referenced
this pull request
Apr 12, 2019
Here's a branch of this: https://github.com/ehirdoy/light_actor/tree/bi-tcp%2Bfrag%2Bstorage2 This requires some patch: mirage/ocaml-fat#81 from ocaml-fat $ cd light_actor/test/mirage $ wget http://yann.lecun.com/exdb/mnist/train-images-idx3-ubyte.gz $ wget http://yann.lecun.com/exdb/mnist/train-labels-idx1-ubyte.gz $ ./split-mnist-data $ mirage clean ; mirage configure -t unix --kv_ro=direct && make depend && make On 3 terminals repectively run: $ ./lwae $ ./lwae --uuid=w0 $ ./lwae --uuid=w1 --port=6001 Or for Unikernrel: $ mirage clean ; mirage configure -t hvt --kv_ro=fat && make depend && make On 3 terminals repectively run: $ ./start-actor server $ ./start-actor w0 $ ./start-actor w1 Signed-off-by: Hiroshi Doyu <hiroshi.doyu@ericsson.com>
ehirdoy
pushed a commit
to ehirdoy/light_actor
that referenced
this pull request
Apr 12, 2019
Here's a branch of this: https://github.com/ehirdoy/light_actor/tree/bi-tcp%2Bfrag%2Bstorage2 This requires some patch: mirage/ocaml-fat#81 from ocaml-fat $ cd light_actor/test/mirage $ wget http://yann.lecun.com/exdb/mnist/train-images-idx3-ubyte.gz $ wget http://yann.lecun.com/exdb/mnist/train-labels-idx1-ubyte.gz $ ./split-mnist-data $ mirage clean ; mirage configure -t unix --kv_ro=direct && make depend && make On 3 terminals repectively run: $ ./lwae $ ./lwae --uuid=w0 $ ./lwae --uuid=w1 --port=6001 Or for Unikernrel: NOTE: MirageOS requires opam2 $ mirage clean ; mirage configure -t hvt --kv_ro=fat && make depend && make On 3 terminals repectively run: $ ./start-actor server $ ./start-actor w0 $ ./start-actor w1 Signed-off-by: Hiroshi Doyu <hiroshi.doyu@ericsson.com>
ehirdoy
pushed a commit
to ehirdoy/light_actor
that referenced
this pull request
Apr 17, 2019
Here's a branch of this: https://github.com/ehirdoy/light_actor/tree/bi-tcp%2Bfrag%2Bstorage2 This requires some patch: mirage/ocaml-fat#81 from ocaml-fat $ cd light_actor/test/mirage $ wget http://yann.lecun.com/exdb/mnist/train-images-idx3-ubyte.gz $ wget http://yann.lecun.com/exdb/mnist/train-labels-idx1-ubyte.gz $ ./split-mnist-data $ mirage clean ; mirage configure -t unix --kv_ro=direct && make depend && make On 3 terminals repectively run: $ ./lwae $ ./lwae --uuid=w0 $ ./lwae --uuid=w1 --port=6001 Or for Unikernrel: NOTE: MirageOS requires opam2 $ mirage clean ; mirage configure -t hvt --kv_ro=fat && make depend && make On 3 terminals repectively run: $ ./start-actor server $ ./start-actor w0 $ ./start-actor w1 Signed-off-by: Hiroshi Doyu <hiroshi.doyu@ericsson.com>
ehirdoy
pushed a commit
to ehirdoy/light_actor
that referenced
this pull request
Apr 25, 2019
This requires some patch: mirage/ocaml-fat#81 from ocaml-fat On 3 terminals repectively run: $ ./lwae $ ./lwae --uuid=w0 $ ./lwae --uuid=w1 --port=6001 Or for Unikernrel: NOTE: MirageOS requires opam2 $ mirage clean ; mirage configure -t hvt --kv_ro=fat && make depend && make $ ./runall Signed-off-by: Hiroshi Doyu <hiroshi.doyu@ericsson.com>
|
Thanks! |
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Nov 21, 2019
CHANGES: - fix inconsistent sector size between block and fs (mirage/ocaml-fat#81, @ehirdoy) - adapt to newer MirageOS 3.7.1 interfaces (mirage/ocaml-fat#82, @hannesm) - Handle special dot and dotdot files (mirage/ocaml-fat#76, @ricarkol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let page = alloc 4096 inseems to force read 4KiBbut its unit should be FAT sector size.
This fixes "mirage-skeleton/device-usage/kv_ro",
configured with hvt && --kv_ro=fat.
Signed-off-by: Hiroshi Doyu hiroshi.doyu@ericsson.com