add Cstruct.sub_copy
#305
Merged
add Cstruct.sub_copy
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosaure
approved these changes
Nov 17, 2022
|
good point, done. |
|
Thanks, let's merge. I will try to find a window to cut a release. |
|
Hi! I was just looking for this function in the interface without finding it. I was wondering if it would make sense to call it |
|
I'm not a maintainer, but an option could be to put an alert on |
Merged
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Feb 20, 2023
…ct-lwt and cstruct-async (6.2.0) CHANGES: - Add `sub_copy` function (@c-cube, mirage/ocaml-cstruct#305) - Fix documentation (@MisterDA, mirage/ocaml-cstruct#304) - Add `to_hex_string` function (@c-cube, mirage/ocaml-cstruct#306) - Fix documentation and use `Cstruct.length` instead of `Cstruct.len` (@reynir, mirage/ocaml-cstruct#307) - Deprecate `copy` function (alias of `to_string`) (will be removed at the next minor release) (@reynir, mirage/ocaml-cstruct#308)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking for a way of copying a
Cstruct.twithout sharing the buffer (because the buffer is used for the next IO read), and did not find one.