Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppx_cstruct: remove stdlib-shims dependency, it requires OCaml 4.08 already #300

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Jul 4, 2022

somehow overlooked in #298

@hannesm
Copy link
Member Author

hannesm commented Jul 4, 2022

//cc @dinosaure

@hannesm
Copy link
Member Author

hannesm commented Jul 4, 2022

any idea what the "drone" CI issue is? it reports that some crashes have been found, but I'm not able to reproduce. any help?

@samoht
Copy link
Member

samoht commented Jul 4, 2022

17:19.18:[ERROR]All fuzzers finished, but some crashes were found!

That's indeed not super helpful!

Copy link
Member

@dinosaure dinosaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to take a look tomorrow.

@dinosaure
Copy link
Member

The error seems related to an OOM. It's reproducible on my machine if I do:

$ cd _build/default/fuzz
$ afl-fuzz -m 200 -i input -o output -S 3 -- ./fuzz.exe @@

I'm not sure how to fix that and even if I put something larger than 200 (with the -m option), the fuzzer continue to fail. It's probably an error into the fuzz.exe than the afl-fuzz - may be, it allocates a lot. In any way, I will make an issue about that and merge this PR when the problem seems unrelated.

@dinosaure
Copy link
Member

See #301 for the error.

@dinosaure dinosaure merged commit 3801d1d into mirage:main Jul 20, 2022
@hannesm hannesm deleted the ppx-no-stdlib-shims branch July 24, 2022 13:59
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jul 24, 2022
…ct-lwt and cstruct-async (6.1.1)

CHANGES:

- ppx_cstruct: remove superfluous stdlib-shims dependency (@hannesm mirage/ocaml-cstruct#300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants