Add a deprecation on Cstruct.len (use Cstruct.length instead) #284
Conversation
|
is the predicate |
|
According to the official documentation, both can be used, but I can prepend with |
|
@dinosaure thanks, I tested this locally, and it works great. I enabled OCaml-CI on this repository. Good to merge once CI (should we remove travis?) are finished. |
|
The CI fails on the linter about About Travis CI, I prefer to be conservative on CIs or we should open an issue to discuss about that. |
I read this morning ocaml/ocaml-ci-scripts#353 -- and I don't see a good reason to use travis in this repository (given that github actions and ocaml-ci are doing a good job :)
fine with me to fix that CI issue in a different PR :) good to merge this PR from my side. |
…ct-lwt and cstruct-async (6.0.1) CHANGES: **breaking changes** - `Cstruct.len` is deprecated, it will be deleted at the next release. You should use `Cstruct.length` instead. (@dinosaure, @hannesm, mirage/ocaml-cstruct#284) - Remove color from ppx's binary to replicate diff of errors in any contexts (@dinosaure, @sternenseemann, mirage/ocaml-cstruct#285) - Add `shiftv` (@talex5, @avsm, @dinosaure, mirage/ocaml-cstruct#287) - Use `Bytes_val` if available (@hannesm, @avsm, @dinosaure, mirage/ocaml-cstruct#286)
…ct-lwt and cstruct-async (6.0.1) CHANGES: **breaking changes** - `Cstruct.len` is deprecated, it will be deleted at the next release. You should use `Cstruct.length` instead. (@dinosaure, @hannesm, mirage/ocaml-cstruct#284) - Remove color from ppx's binary to replicate diff of errors in any contexts (@dinosaure, @sternenseemann, mirage/ocaml-cstruct#285) - Add `shiftv` (@talex5, @avsm, @dinosaure, mirage/ocaml-cstruct#287) - Use `Bytes_val` if available (@hannesm, @avsm, @dinosaure, mirage/ocaml-cstruct#286)
…ct-lwt and cstruct-async (6.0.1) CHANGES: **breaking changes** - `Cstruct.len` is deprecated, it will be deleted at the next release. You should use `Cstruct.length` instead. (@dinosaure, @hannesm, mirage/ocaml-cstruct#284) - Remove color from ppx's binary to replicate diff of errors in any contexts (@dinosaure, @sternenseemann, mirage/ocaml-cstruct#285) - Add `shiftv` (@talex5, @avsm, @dinosaure, mirage/ocaml-cstruct#287) - Use `Bytes_val` if available (@hannesm, @avsm, @dinosaure, mirage/ocaml-cstruct#286)
According to #282 to be ready (and to not forget) for a possible next release.