Upgrade ocaml-migrate-parsetree to support latest ocaml #275
Conversation
… address lwt_ppx errors
| @@ -1,2 +1,5 @@ | |||
| (lang dune 1.0) | |||
| (lang dune 2.0) | |||
There was a problem hiding this comment.
This needs the ppx_cstruct.opam to have a corresponding dune {>= "2.0.0"} entry.
There was a problem hiding this comment.
Sorry, just one last change needed here before merge. Since the dune-project affects all the associated projects, every opam package needs a corresponding dune >2 entry. e.g. the Drone CI is failing as its trying to install cstruct with dune 1.11 and that no longer works.
There was a problem hiding this comment.
I have now added dune {>= "2.0.0"} constraint to all .opam files in repo.
| @@ -10,5 +10,5 @@ type foo64 = | |||
| [@@uint64_t] | |||
| ] | |||
|
|
|||
| let%lwt foo = Lwt.return () | |||
| let foo = Lwt_main.run (Lwt.return ()) | |||
There was a problem hiding this comment.
Why change this? That use of let%lwt was there in the test suite was there to check that ppx_cstruct and ppx_lwt work together.
There was a problem hiding this comment.
The recent version of ppx_lwt gives the warning below,
File "ppx_test/with-lwt/ppx_cstruct_and_lwt.ml", line 13, characters 0-27:
Error (warning 22): let%lwt should not be used at the module item level.
Replace let%lwt x = e by let x = Lwt_main.run (e)
I have now modified the test to use let%lwt inside rather than at the module toplevel to get around the warning.
There was a problem hiding this comment.
Good call; there should be no interop problems with modern ppx, but there were in the past, so its good to keep the test around.
|
@avsm all checks are green. I think it is ready to merge. |
|
Thanks! Releasing shortly. |
…uct-sexp and cstruct-lwt (5.2.0) CHANGES: Upgrade the `ppx_cstruct` library to use the OCaml 4.11 AST rather than than OCaml 4.04, which in turn should make it easier to port to ppxlib in the future and improve interoperability with other PPXs (@bikallem mirage/ocaml-cstruct#275). Also upgrades build files to use dune 2.0 (@bikallem mirage/ocaml-cstruct#275) and fixes the GitHub Actions versions (@smorimoto mirage/ocaml-cstruct#273) and also test OCaml 4.10.0 (@avsm).
This PR upgrades the ocaml-migrate-parsetree to the latest version supporting ocaml up to version 4.11.
The PR also upgrades dune to v2.0 to address some dune warnings.
All tests pass.