len attribute should be an int literal #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes mirage#264 This rejects things like `[@len ""]` and `[@len 1l]` which were previously silently ignored.
|
ppxlib has some combinators to avoid this kind of boilerplate - might be worth investigating if we split the ppx out of the main cstruct package. |
|
I'd be delighted to get a ppx/ppxlib port of ppx_cstruct.. |
avsm
requested changes
Sep 2, 2019
| ; _}])] -> | ||
| Some (int_of_string sz) | ||
| | [{txt = "len"; loc}, _ ] -> | ||
| loc_err loc "[@len] argument should be an integer" |
There was a problem hiding this comment.
Suggested change
| loc_err loc "[@len] argument should be an integer" | |
| loc_err loc "[@len] argument should be a positive, non-zero integer" |
There was a problem hiding this comment.
there are two check sites so I used this more specific version only when needed, how does that look?
|
Looks good to me! Unrelated to this PR, but the tests fail on 4.08 since ppx_cstruct generates references to stdlib. I'll fix that in a separate PR. |
|
Yes that's #263 - the environment variable should do it. Thanks! |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Nov 24, 2019
…uct-sexp and cstruct-lwt (5.1.0) CHANGES: - Do not issue deprecation warnings when using OCaml 4.08.0 and cstruct-ppx with enums due to `Pervasives` (mirage/ocaml-cstruct#269 @cypheon @hannesm) - Tighten parsing of the `[@len]` attribute to ensure it is a valid, positive integer (mirage/ocaml-cstruct#265 @emillon) - Update JavaScript bindings to latest `Js_of_ocaml` 3.5.0 interfaces (@hhugo mirage/ocaml-cstruct#268)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264
This rejects things like
[@len ""]and[@len 1l]which were previously silently ignored.