Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt unix/charruad to newer cmdliner. #117

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

haesbaert
Copy link
Member

Syntax changed, so also constrict cmdliner version to >= 1.1.0

Syntax changed, so also constrict cmdliner version to >= 1.1.0
unix/charruad.ml Outdated Show resolved Hide resolved
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
@haesbaert
Copy link
Member Author

I'm also piggybacking the ip random change here, should be a no brainer.

@hannesm
Copy link
Member

hannesm commented Mar 2, 2022

since it is only a single packet, the IP id is really irrelevant (and you can also leave it as 0) -- or am I mistaken?

Copy link
Member

@hannesm hannesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge

@haesbaert haesbaert merged commit 6f79bbd into mirage:main Mar 2, 2022
hannesm added a commit to hannesm/opam-repository that referenced this pull request Dec 9, 2024
CHANGES:

* charruad: update to new cmdliner (mirage/charrua#117 @haesbaert)
* support mtime >= 2.0.0 (mirage/charrua#121 @haesbaert, @tmcgilchrist)
* charrua-unix: use duration package (mirage/charrua#122 @hannesm)
* replace Cstruct.copy by Cstruct.to_string (mirage/charrua#123 @gridbugs)
* use mirage-crypto-rng instead of mirage-random-test (mirage/charrua#126 @hannesm)
* remove mirage-random dependency, use mirage-crypto-rng instead - and update
  to mirage-crypto-rng >= 1.0.0 (mirage/charrua#127 @hannesm)
* remove ppx_cstruct and sexplib from dependency cone (mirage/charrua#128 @hannesm)
* charrua-client: update to tcpip >= 8.1.0 (mirage/charrua#129 @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants