less packages, less abstraction #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the charrua-client packages into a single one, use sublibraries charrua-client.lwt and charrua-client.mirage to control runtime dependencies. From opam-repository, charrua-client is used in MirageOS only, the motivation is to reduce the overhead by reducing the number of packages.
There's no need for abstraction (over a module type) since we did not develop any other DHCP implementation in recent years. Abstraction currently comes with a price, hardcoded code in the mirage utility - which we want to minimize. This also removes the dependency on Mirage_protocols.ipv4_config. It will require a version bump to avoid an old mirage utility to use this new code (which module signature is different now).
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Nov 25, 2020
…t (1.3.0) CHANGES: * Revise packaging: charrua-client-lwt and charrua-client-mirage are now available as charrua-client.lwt and charrua-client.mirage (mirage/charrua#110 @hannesm) * Dhcp_ipv4 directly uses Dhcp_client_mirage (instead of an abstract module interface being passed) (mirage/charrua#110 @hannesm) * Fix sending of client_identifier with appropriate type as sent by the client (mirage/charrua#98 @hannesm, reported in mirage/charrua#84 by @lynxis)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to have fewer packages, and more straightforward code. See individual commits for what has been achieved.