[pull] master from buildroot:master #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
With the new 'buildx' command using 'BuildKit' since Docker 23.0 [1], it become easy to build the same image for several architectures [2]. The only requirement is to use a Dockerfile without any architecture specific definition. Since our current Dockefile contains already some i386 specific packages (g++-multilib,libc6:i386) to provide x86 32bits support, we have to install them conditionally. Update the build process described in the Dockerfile accordingly. For now, Aarch64 hosts can't be used by the Buildroot testsuite (yet) since the Bootlin external toolchain (used by default) currently only support x86_64 hosts. [1] https://docs.docker.com/engine/release-notes/23.0/ [2] https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/ [3] https://www.docker.com/blog/multi-arch-build-what-about-gitlab-ci/ Signed-off-by: Romain Naour <romain.naour@smile.fr> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildx correctly complains about our ENV lines: 3 warnings found (use docker --debug to expand): - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 21) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 94) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 95) The ENV syntax is defined as ENV FOO=BAR, not ENV FOO BAR, so adjust the Dockerfile to match to get rid of this warning. https://docs.docker.com/reference/dockerfile/#env Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )