Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Divider95 Widget #25

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Added Divider95 Widget #25

merged 1 commit into from
Oct 24, 2023

Conversation

Taosif7
Copy link
Contributor

@Taosif7 Taosif7 commented Oct 24, 2023

Added Tests, Example, Docs

@Taosif7 @taosif7-dreamorbit
feat: Added Divider95 Widget
0f2022a 
- Added Tests
- Added Example
- Added Docs
miquelbeltran
miquelbeltran approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say, I wasn't really convinced about the class parameters, but then I looked at the Divider class in Flutter, and it does exactly the same :) https://api.flutter.dev/flutter/material/Divider-class.html

@miquelbeltran miquelbeltran merged commit 18a3a0a into miquelbeltran:master Oct 24, 2023
@miquelbeltran
Copy link
Owner

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miquelbeltran miquelbeltran miquelbeltran approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Taosif7 @miquelbeltran