Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: button border-style #390

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix: button border-style #390

merged 2 commits into from
Oct 4, 2023

Conversation

ppvg
Copy link
Member

@ppvg ppvg commented Oct 2, 2023

This PR adds default values for all the --button-base-*-border-style and --button-base-*-border-width vars. These vars being undefined resulted in the :active, :focus and :selected button states getting the equivalent of border-style: unset, which causes unexpected behaviour on buttons, leaving them without a border, even if border-width is set later.

@ppvg ppvg marked this pull request as ready for review October 4, 2023 09:25
@ppvg ppvg requested review from TwistMeister and a team as code owners October 4, 2023 09:25
@HeleenSG HeleenSG merged commit f0db991 into main Oct 4, 2023
@HeleenSG HeleenSG deleted the fix/button-border-style branch October 4, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeleenSG HeleenSG HeleenSG approved these changes

@TwistMeister TwistMeister Awaiting requested review from TwistMeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppvg @HeleenSG