-
Notifications
You must be signed in to change notification settings - Fork 36
GitHub Actions Patch (continuous integration testing & reproducible builds) #20
Conversation
@JolandaVerhoef @rvandijke Please review (and merge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for rewriting this using github actions. I'll merge this internally and it will be part of the next public code push. The PR will be closed then.
Lovely ! |
Moet je nog niet een pull hebben ? |
6c8ea23
to
7bcc968
Compare
@rvandijke @dirkx I have reorganised the code in the PR a bit (and squashed the many commits together) and will need a re-review. The prep and build phases now run succesfull, but the test phase now throws a (legitimate) error:
|
Very nice !
|
Thank you so much for writing this using Github Actions! |
Will have a look today! |
In able to resolve the xcodebuild error (and to merge this successfully) Xcodegen needs to be patched: I've upvoted the issue and will have a look at putting up a PR myself for it, but at this moment I do have a few more important priorities. @jsoeterbroek do you think this is something you could take up by chance? A downside of relying on Xcodegen, but it already saved us a lot of time :) |
Building and testing now runs successfully all the way through for example target 'iphone 11'. Unittests are mostly successfull, but not completely (see also test log attached):
|
Thanks for updating. Will patch it locally and review it right now |
This has been landed (by rebasing) |
This patch allows for GitHub Actions CI.