Use string contains check on verification output #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaytaph
approved these changes
Dec 12, 2022
|
Waarom? Dit is gevaarlijk(!!) |
|
Niet echt nee (!!). Dit is een ssllibre check. De "echte" check of verificatie goed gaat wordt door de exitcode gedaan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We throw a crypto exception when the output does not start with
Verification successfulofVerification failure.For the latest opensssl version this message is changed to
CMS Verification successfulandCMS Verification failure.Based on the process exitcode the validation is successful or not, so we do not update the validation logic. This change only updates when we throw an crypto exception if there is an output we did not expect.