Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/wallet generic signer #1783

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
40b19db
Add SignerProvider generic to the wallet
OBorce Jun 12, 2024
aabfca5
Add optional trezor signer support
OBorce Jun 18, 2024
a563999
add trezor-client generated code
OBorce Jun 20, 2024
2b950b4
add trezor-client generated code
OBorce Jun 20, 2024
9fb7297
add trezor-client generated code
OBorce Jun 20, 2024
1cafef7
refactor signer provider for creating wallet accounts
OBorce Jul 1, 2024
413f331
Add trezor hardware wallet Account implementation
OBorce Jul 2, 2024
1b1ebcb
add cli command arguments for creating trezor wallet
OBorce Jul 2, 2024
6ca2bbf
add support for all inputs and outputs to trezor signer
OBorce Jul 15, 2024
77b68b8
add support for signing challenges with trezor
OBorce Jul 29, 2024
2df804e
Add support for trezor wallet in node gui
OBorce Jul 30, 2024
8dfd74c
fix pipeline errors
OBorce Jul 30, 2024
2b5e363
fix trezor feature compilation
OBorce Jul 31, 2024
2d79ff7
update rpc docs
OBorce Aug 1, 2024
585cfad
remove the trezor client code and reference the git repository
OBorce Aug 6, 2024
ae99ba1
add support for Hot wallet with trezor device
OBorce Aug 12, 2024
fde2a1f
add wallet-recover command
OBorce Aug 13, 2024
2ee0e0b
add additional UTXO info to partially signed tx
OBorce Aug 6, 2024
d65bab9
add additional UTXO info to partially signed tx
OBorce Aug 6, 2024
0023d11
update RPC docs
OBorce Aug 7, 2024
e6450d0
add additional token info for utxos in partially signed tx
OBorce Aug 15, 2024
89d3a9f
clean up from review comments
OBorce Aug 16, 2024
1c14326
update rpc docs
OBorce Aug 16, 2024
8c5932e
Add additional utxo info for tx outputs
OBorce Aug 20, 2024
ad37936
move PartiallySignedTx to wallet
OBorce Aug 20, 2024
e236789
refactor review comments
OBorce Aug 21, 2024
aba9987
refactor wallet utxo token_id uses
OBorce Aug 24, 2024
fdc3715
add separate additional data for anyonecanstake
OBorce Aug 26, 2024
2ad94fd
add support for signing HTLC outputs with trezor
OBorce Aug 27, 2024
7589749
fix comments
OBorce Aug 29, 2024
1e18f52
extract runtime wallet functionality
OBorce Aug 30, 2024
d00d161
fix functional tests
OBorce Aug 31, 2024
35b4db9
fix trezor test
OBorce Sep 10, 2024
955fd6c
add ChangeTokenMetadataUri to trezor singer
OBorce Sep 10, 2024
c4b6bca
Convert TrezorError to string
OBorce Sep 11, 2024
d7775a2
Add support for orders in trezor
OBorce Sep 17, 2024
cbdffea
fix trezor produce from stake additional info
OBorce Sep 17, 2024
b3b9ce3
add all inputs/outputs to trezor test
OBorce Sep 20, 2024
66a3bc7
fix fill order change after rebase
OBorce Oct 14, 2024
2e88f4b
Update trezor dependency and new messages
OBorce Oct 31, 2024
722d70e
Reuse referenced tokens util in API Server
OBorce Oct 31, 2024
6713e04
Add test with signatures from trezor
OBorce Nov 13, 2024
1d766e5
fix comments
OBorce Dec 2, 2024
511bba3
Implement sign tx intent for Trezor signer
OBorce Dec 9, 2024
46cf688
remove default feature
OBorce Dec 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ jobs:
- name: Install rust
run: curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain $(python3 ./build-tools/rust-version-extractor/rust-version-extractor.py)
- name: Build
run: cargo build --release --locked
run: cargo build --release --locked --features trezor
- name: Run tests
run: cargo test --release --workspace
run: cargo test --release --workspace --features trezor
- name: Run doc tests
run: cargo test --release --doc
run: cargo test --release --doc --features trezor
# This test is ignored, so it needs to run separately.
- name: Run mixed_sighash_types test
run: cargo test --release mixed_sighash_types
run: cargo test --release mixed_sighash_types --features trezor
# This test is ignored, so it needs to run separately.
- name: Run test_4opc_sequences test
run: cargo test --release test_4opc_sequences -- --ignored
Expand Down Expand Up @@ -65,14 +65,14 @@ jobs:
- name: Install rust
run: curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain $(python3 ./build-tools/rust-version-extractor/rust-version-extractor.py)
- name: Build
run: cargo build --release --locked
run: cargo build --release --locked --features trezor
- name: Run tests
run: cargo test --release --workspace
run: cargo test --release --workspace --features trezor
- name: Run doc tests
run: cargo test --release --doc
run: cargo test --release --doc --features trezor
# This test is ignored, so it needs to run separately.
- name: Run mixed_sighash_types test
run: cargo test --release mixed_sighash_types
run: cargo test --release mixed_sighash_types --features trezor
# This test is ignored, so it needs to run separately.
- name: Run test_4opc_sequences test
run: cargo test --release test_4opc_sequences
Expand All @@ -97,14 +97,14 @@ jobs:
- name: Install rust
run: curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain $(python3 ./build-tools/rust-version-extractor/rust-version-extractor.py)
- name: Build
run: cargo build --release --locked
run: cargo build --release --locked --features trezor
- name: Run tests
run: cargo test --release --workspace
run: cargo test --release --workspace --features trezor
- name: Run doc tests
run: cargo test --release --doc
run: cargo test --release --doc --features trezor
# This test is ignored, so it needs to run separately.
- name: Run mixed_sighash_types test
run: cargo test --release mixed_sighash_types
run: cargo test --release mixed_sighash_types --features trezor
# This test is ignored, so it needs to run separately.
- name: Run test_4opc_sequences test
run: cargo test --release test_4opc_sequences
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:

- name: Build
run: |
cargo build --release --target ${{ matrix.arch }}-unknown-linux-gnu
cargo build --release --target ${{ matrix.arch }}-unknown-linux-gnu --features trezor

- name: Create Debian package for GUI
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- name: Build
run: |
cargo build --release --target ${{ matrix.arch }}-apple-darwin
cargo build --release --target ${{ matrix.arch }}-apple-darwin --features trezor

- name: Sign and Notarize GUI
env:
Expand Down Expand Up @@ -67,4 +67,4 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: Mintlayer_Node_macos_${{ steps.get_version.outputs.VERSION }}_${{ matrix.arch }}
path: Mintlayer_Node_macos_${{ steps.get_version.outputs.VERSION }}_${{ matrix.arch }}.zip
path: Mintlayer_Node_macos_${{ steps.get_version.outputs.VERSION }}_${{ matrix.arch }}.zip
4 changes: 2 additions & 2 deletions .github/workflows/release_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
toolchain: stable

- name: Build Mintlayer Node and GUI
run: cargo build --release
run: cargo build --release --features trezor

- name: Package Mintlayer Node
run: |
Expand Down Expand Up @@ -99,4 +99,4 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: Mintlayer_Node_GUI_win_${{ steps.get_version.outputs.VERSION }}_Setup
path: Mintlayer_Node_GUI_win_${{ steps.get_version.outputs.VERSION }}_Setup.exe
path: Mintlayer_Node_GUI_win_${{ steps.get_version.outputs.VERSION }}_Setup.exe
Loading
Loading