Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow comments in things. #714

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Allow comments in things. #714

merged 3 commits into from
Nov 24, 2024

Conversation

gdotdesign
Copy link
Member

This PR makes it so that comments are parsed in previously not allowed places:

  • Between array and tuple items
  • At the end of arrays, tuples, records and type definitions
  • Before operators (mostly for pipes)

Fixes #634 #635
See also: https://discord.com/channels/698214718241767445/701755309307199508/1308863613062221965

@gdotdesign gdotdesign added the enhancement New feature or request label Nov 23, 2024
@gdotdesign gdotdesign requested a review from Sija November 23, 2024 13:38
@gdotdesign gdotdesign self-assigned this Nov 23, 2024
Sija
Sija approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@Sija Sija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdotdesign gdotdesign merged commit 35aff16 into master Nov 24, 2024
3 checks passed
@gdotdesign gdotdesign deleted the comments-in-lists branch November 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija approved these changes

Assignees

@gdotdesign gdotdesign

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow comments in the middle of arrays
2 participants
@gdotdesign @Sija