Refactor how location of nodes are calculated. #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Nov 12, 2024
Instead of calculating the location (line, column) of a node after the fact it is now part of the parser.
gdotdesign
force-pushed
the
node-location-refactor
branch
from
1461d23 to
3037cd1
Compare
Sija
reviewed
Nov 14, 2024
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source map generation triggered this refactor, but it was on my radar for a while.
The location calculation was previously done on demand, which meant that it was a performance problem because it iterates over the lines of the source files many times. It wasn't an issue before because only the language server was using it, but now with the source maps it presented an opportunity for refactoring.
In the new version, the parser keeps track of the location during parsing. Positions of AST nodes now include the line and column along with the offset (that's why all node files changed).
Now, source map generation time is down and parsing time don't seem to be affected (subject project
mint-website).