Move to GitHub actions #196
Conversation
|
We're green - https://github.com/alexpott/MinkZombieDriver/actions/runs/1319628245 I guess now we need to decide about the Zombie versions / node versions we want to test on. Could do that in the follow-up given how broken the CI currently is. |
.github/workflows/tests.yml
Outdated
| zombie_version: [ '@^3.0' ] | ||
| node: [ '5' ] |
There was a problem hiding this comment.
You seem to be using NodeJS 5.0 + Zombie 3.0 for all PHP versions.
Compared to .travis.yml (see https://github.com/minkphp/MinkZombieDriver/blob/master/.travis.yml#L11-L27) we test on:
- Zombie 3.0 + distributive installed NodeJS on all PHP versions
- Zombie 2.0 + distributive installed NodeJS on PHP 5.6 version
- Zombie 4.0 + NodeJS 5.4.1 on PHP 5.6 version
There was a problem hiding this comment.
I was just trying to get this running. Compared to travis where everything is currently broken this is a massive improvement. That said testing with Zombie 3 or 4 is a bit silly because even the latest version of Zombie (6) is several years old.
There was a problem hiding this comment.
Okay current matrix tests Zombie 2,3,4,5 and Node 5,10,16 and PHP 5.4 -> 8.1 - and is all green. I think this is a way better situation. We could open an MR to add Zombie 6 testing - this will need fixes to the code and should not be done here.
|
Maybe the |
alexpott
force-pushed
the
move-to-github-actions
branch
from
0249677 to
c9907a7
Compare
|
A green run of the current MR: https://github.com/alexpott/MinkZombieDriver/actions/runs/1325323856 |
Still struggling to get PHP ^7.4 passing.