Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump govuk_tech_docs from 2.0.12 to 2.0.13 #93

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps govuk_tech_docs from 2.0.12 to 2.0.13.

Release notes

Sourced from govuk_tech_docs's releases.

v2.0.2 - GOV.UK Frontend migration

We’ve moved the gem off the deprecated GOV.UK Frontend Toolkit and onto GOV.UK Frontend.

This will help it to meet WCAG 2.1 level AA.

To get the assets pipeline to work we also had to upgrade the ruby-version too, we went with 2.6.3 but technically anything >2.5 will be fine.

Changelog

Sourced from govuk_tech_docs's changelog.

2.0.13

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@digitalronin
Copy link
Contributor

The changes in this point release are tiny (alphagov/tech-docs-gem#189) and do not affect any features we use in this repo. So, I'd recommend skipping this update, and probably most others until we can use an unpatched version of the tech docs gems.

Although this repo has to contain a Gemfile and Gemfile.lock, the actually gems used are the ones in the docker image created via this code: ministryofjustice/cloud-platform-user-guide#393

So, keeping the gems in sync is more difficult than it would normally be.

I completely understand that this is an unfortunate hack, and hopefully we can do away with that as soon as the required fixes to enable search to work at a non-root docpath have been merged into the upstream project. But for now, because these Gemfile* files are just placeholders, and all we do with this repo is generate static html/js files via a separate docker image, I recommend skipping this update.

@SteveMarshall
Copy link
Contributor

@digitalronin Thanks for the clarification! I'll close this for now. Are you OK to keep an eye for when we can bring this back in line with the main tech-docs-template gem?

@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@SteveMarshall SteveMarshall deleted the dependabot/bundler/govuk_tech_docs-2.0.13 branch August 7, 2020 09:31
@digitalronin
Copy link
Contributor

Yes, definitely @SteveMarshall I'm communicating with the relevant GDS team via github, so I should know pretty quickly if/when they fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants