Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #1118

Merged
merged 11 commits into from
Nov 4, 2024
Merged

Various fixes #1118

merged 11 commits into from
Nov 4, 2024

Conversation

vertism
Copy link
Contributor

@vertism vertism commented Nov 1, 2024

Description

  • Fixes earlybird to remove navigation
  • Remove statsd
  • Remove GA events
  • Remove legacy code (emails, members controller)

@vertism vertism changed the base branch from main to full-design-system-update November 1, 2024 16:42
@vertism vertism changed the title Fix earlybird page Various fixes Nov 1, 2024
@vertism vertism marked this pull request as ready for review November 1, 2024 17:11
@vertism vertism requested review from a team as code owners November 1, 2024 17:11
@lucas-shaw
Copy link
Contributor

I had to run rails assets:precompile as i was originally getting an error

ActionView::Template::Error (The asset "application.css" is not present in the asset pipeline.
):

Causes:
Sprockets::Rails::Helper::AssetNotFound (The asset "application.css" is not present in the asset pipeline.
)
    14:     <%= favicon_link_tag asset_path('govuk-frontend/dist/govuk/assets/images/govuk-icon-mask.svg'), rel: 'mask-icon', color: '#0b0c0c' %>
    15:     <%= favicon_link_tag asset_path('govuk-frontend/dist/govuk/assets/images/govuk-icon-180.png'), rel: 'apple-touch-icon', type: 'image/png', size: '180x180' %>
    16:
    17:     <%= stylesheet_link_tag "application", "font-awesome/css/font-awesome" %>
    18:
    19:     <%= javascript_include_tag "application", defer: true %>
    20:

@vertism vertism merged commit ce295e6 into full-design-system-update Nov 4, 2024
8 checks passed
@vertism vertism deleted the fix-earlybird branch November 4, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants