Resolve SAML assertion issues #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,7 +52,8 @@ exports.onExecutePostLogin = async (event, api) => { | |||
| // Set SAML attribute for the user's GitHub team memberships | |||
| const userTeamsResponse = await octokit.request('GET /user/teams').catch(error => api.access.deny(`Error retrieving teams from GitHub: ${error}`)) | |||
| const userTeamSlugs = userTeamsResponse.data.map(team => team.slug) | |||
| api.samlResponse.setAttribute('https://aws.amazon.com/SAML/Attributes/PrincipalTag:github_team', userTeamSlugs.join(',')) | |||
| console.log("Joined the following teams:" `${userTeamSlugs.join(',')}`) | |||
There was a problem hiding this comment.
Logline needs updating to 👇
Suggested change
| console.log("Joined the following teams:" `${userTeamSlugs.join(',')}`) | |
| console.log(`Joined the following teams: ${userTeamSlugs.join(',')}`) |
Interpreter is getting confused about two separate strings being passed to the join function 🙈
Will also need to update the test on line 64 to 👇
- ['https://aws.amazon.com/SAML/Attributes/PrincipalTag:github_team', 'test-team-1,test-team-2'],
+ ['https://aws.amazon.com/SAML/Attributes/AccessControl:github_team', 'test-team-1,test-team-2'],To reflect the new changes 🧪 🪞 😁
… and doesn't need to be defined in code
dms1981
changed the title
connormaglynn
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to how github teams are passed back as a SAML attribute to AWS.
PrincipalTagtoAccessControlin line with this guidance.