-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add interruption card #988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add in the macro template and styles for the interruption card component. Based on the component in use in HMPPS seen here: https://github.com/ministryofjustice/hmpps-book-a-prison-visit-ui/pull/156/files with changes made according to decisions based upon research and discovery.
Adding documentation page and nav link for interruption card.
add in the macro template and styles for the interruption card component. Based on the component in use in HMPPS seen here: https://github.com/ministryofjustice/hmpps-book-a-prison-visit-ui/pull/156/files with changes made according to decisions based upon research and discovery.
Adding documentation page and nav link for interruption card.
…justice/moj-frontend into add-interruption-card
…justice/moj-frontend into add-interruption-card
- Change content wrapper width from fluid to fixed for readability - Update example iframe height ✅ Closes: 936
* docs(pagination): update results indexes on pagination example The paginion component example shows as page 2, but also outputs "showing results 10-20 of 30". This commit updates that to be results 11-20 as would actually be displayed. * fix(pagination): fix aria label for pages to use total pages instead of total results The `aria-label` for each page entry was of the form "page x of y" where y was the total number of results, rather than the total number of pages. This PR fixes the error --------- Co-authored-by: Chris Pymm <chris@chrispymm.co.uk>
- Change content wrapper width from fluid to fixed for readability - Update example iframe height ✅ Closes: 936
…justice/moj-frontend into add-interruption-card
- update example images - update example iframe height
…justice/moj-frontend into add-interruption-card
…ts on the same page (#930)
* docs(pagination): update results indexes on pagination example The paginion component example shows as page 2, but also outputs "showing results 10-20 of 30". This commit updates that to be results 11-20 as would actually be displayed. * fix(pagination): fix aria label for pages to use total pages instead of total results The `aria-label` for each page entry was of the form "page x of y" where y was the total number of results, rather than the total number of pages. This PR fixes the error --------- Co-authored-by: Chris Pymm <chris@chrispymm.co.uk>
…justice/moj-frontend into add-interruption-card
- Figma link added - "What's new" content added
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the interruption card component.