Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add interruption card #988

Merged
merged 80 commits into from
Dec 10, 2024
Merged

feat: Add interruption card #988

merged 80 commits into from
Dec 10, 2024

Conversation

chrispymm
Copy link
Contributor

Adds the interruption card component.

chrispymm and others added 30 commits November 11, 2024 21:28
add in the macro template and styles for the interruption card component.  Based on the component in
use in HMPPS seen here:
https://github.com/ministryofjustice/hmpps-book-a-prison-visit-ui/pull/156/files with changes made
according to decisions based upon research and discovery.
Adding documentation page and nav link for interruption card.
add in the macro template and styles for the interruption card component.  Based on the component in
use in HMPPS seen here:
https://github.com/ministryofjustice/hmpps-book-a-prison-visit-ui/pull/156/files with changes made
according to decisions based upon research and discovery.
Adding documentation page and nav link for interruption card.
- Change content wrapper width from fluid to fixed for readability
- Update example iframe height

✅ Closes: 936
robertjmccarthy and others added 24 commits December 10, 2024 09:49
* docs(pagination): update results indexes on pagination example

The paginion component example shows as page 2, but also outputs
"showing results 10-20 of 30". This commit updates that to be results
11-20 as would actually be displayed.

* fix(pagination): fix aria label for pages to use total pages instead of total results

The `aria-label` for each page entry was of the form "page x of y" where y was the total number of
results, rather than the total number of pages. This PR fixes the error

---------

Co-authored-by: Chris Pymm <chris@chrispymm.co.uk>
- Change content wrapper width from fluid to fixed for readability
- Update example iframe height

✅ Closes: 936
- update example images
- update example iframe height
* docs(pagination): update results indexes on pagination example

The paginion component example shows as page 2, but also outputs
"showing results 10-20 of 30". This commit updates that to be results
11-20 as would actually be displayed.

* fix(pagination): fix aria label for pages to use total pages instead of total results

The `aria-label` for each page entry was of the form "page x of y" where y was the total number of
results, rather than the total number of pages. This PR fixes the error

---------

Co-authored-by: Chris Pymm <chris@chrispymm.co.uk>
- Figma link added
- "What's new" content added
@chrispymm chrispymm requested a review from a team as a code owner December 10, 2024 11:05
@chrispymm chrispymm merged commit 506bf09 into main Dec 10, 2024
35 checks passed
@chrispymm chrispymm deleted the add-interruption-card branch December 10, 2024 11:08
gregtyler pushed a commit that referenced this pull request Dec 10, 2024
# [3.2.0](v3.1.0...v3.2.0) (2024-12-10)

### Features

* Add interruption card ([#988](#988)) ([506bf09](506bf09)), closes [#930](#930) [#956](#956)
@gregtyler
Copy link
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants