Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font specification to pagination results #89

Merged
merged 3 commits into from
May 13, 2020
Merged

Add font specification to pagination results #89

merged 3 commits into from
May 13, 2020

Conversation

gregtyler
Copy link
Contributor

Identify the bug

This fixes bug #88

Description of the change

This ensures that the moj-pagination__result child element of the moj-pagination class have an explicit font-size so will be shown to the user.

I've applied the same rule already used for moj-pagination__item to ensure consistency between the child elements.

Alternative designs

I didn't identify any suitable alternatives.

Possible drawbacks

If a user was overwriting the font size of pagination elements with utility classes, they'd now also have to add a utility class to moj-pagination__result (rather than falling back on the GOV.UK Design System classes)

Verification process

I can't identify any regressions that mmight be caused by this and could be tested.

Release notes

  • Fixed an issue where the pagination results text was hidden in wide browsers

Copy link
Member

@theDustRoom theDustRoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this issue and applying a change to address it.
The proposed changes look good but there is a layout issue which I have commented on in the code change.

gregtyler added 2 commits May 13, 2020 15:15
This is also assumed in to have been adopted from the GOV.UK Design System CSS
@theDustRoom theDustRoom merged commit d98cb80 into ministryofjustice:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants