Add font specification to pagination results #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the bug
This fixes bug #88
Description of the change
This ensures that the
moj-pagination__result
child element of themoj-pagination
class have an explicit font-size so will be shown to the user.I've applied the same rule already used for
moj-pagination__item
to ensure consistency between the child elements.Alternative designs
I didn't identify any suitable alternatives.
Possible drawbacks
If a user was overwriting the font size of pagination elements with utility classes, they'd now also have to add a utility class to
moj-pagination__result
(rather than falling back on the GOV.UK Design System classes)Verification process
I can't identify any regressions that mmight be caused by this and could be tested.
Release notes