Datepicker tests #807
Merged
Datepicker tests #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds tests for all functionality of the datepicker with default config options. This includes keyboard navigation and axe accessibility checks. During testing a couple of small issues were found and fixed: * Date was initialized with an odd format order causing issues during testing * Calculation of the first and last day of the week was incorreect when the last day of the week was a Sunday
helennickols
approved these changes
Sep 30, 2024
helennickols
approved these changes
Sep 30, 2024
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for all functionality of the datepicker with default config options. This includes keyboard navigation and axe accessibility checks.
During testing a couple of small issues were found and fixed:
aria-selectedto mark the currently selected day, howeveraria-selectedis not permitted on buttons, so changed to usingaria-current="date"instead.