feat(navigation): enhance hover styles of navigation links #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtyler
added
the
staging:request
|
🚀 Deploying to staging environment Username: |
github-actions
bot
added
staging:active
robertjmccarthy
approved these changes
Dec 15, 2023
gregtyler
force-pushed
the
fix-primary-nav-hover
branch
from
742dacb to
cbccda7
Compare
gregtyler
changed the title
gregtyler
removed
the
staging:active
gregtyler
force-pushed
the
fix-primary-nav-hover
branch
from
cbccda7 to
5d6d544
Compare
gregtyler
added
the
staging:request
|
🚀 Deploying to staging environment Username: |
github-actions
bot
added
staging:active
github-actions
bot
removed
the
staging:active
Merged
Applies to Primary navigation, Sub navigation and Side navigation. Use the standard GDS link hover colour to ensure links colour contrast is sufficient for readability. Ensure borders follow suit, and ensure they're always on the same side of the element. Fixes #447
gregtyler
force-pushed
the
fix-primary-nav-hover
branch
from
5d6d544 to
5d28440
Compare
|
Done in #565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to Primary navigation, Sub navigation and Side navigation.
Use the standard GDS link hover colour to ensure links colour contrast is sufficient for
readability.
Ensure borders follow suit, and ensure they're always on the same side of the element.
Fixes #447