fix: markup Banner components as regions #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Banner components are given the region role and an appropriate label to identify them. The label is taken from, in order or priority: - The `iconFallbackText` label, if set - The type of banner (e.g. "success", "warning", "information") - The word "banner" I also removed the visually-hidden insertion `iconFallbackText` to avoid duplication: if provided, this is now the region's label.
gregtyler
force-pushed
the
86-banner-text-label
branch
from
0bc5965 to
c5944ea
Compare
|
as an aside, I think we might want to review all currentColour / svg implementations for the inverted contrast mode / windows |
euhyung
approved these changes
May 17, 2022
|
🎉 This PR is included in version 1.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Banner components are given the region role and an appropriate label to identify them.
The label is taken from, in order or priority:
iconFallbackTextlabel, if setI also removed the visually-hidden insertion
iconFallbackTextto avoid duplication: if provided, this is now the region's label.The only possible regression I can think of is if people have written
iconFallbackTextto flow as a full sentence with the text content, which would now be broken up. If someone strictly needed that behaviour, they can simply append the content tohtml.