fix(components): ensure that custom attributes get a space inserted before each one #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the bug
Almost all MoJ design system components do not put correct whitespace around custom attributes in the nunjucks template.
For instance, https://github.com/ministryofjustice/hmpps-incentives-ui/blob/b8892793247cad8af2c2494802ce839e3abdaf99/server/views/pages/analytics/graph-layout.njk#L5-L24 renders as:
…note the absence of a space before each of the
data-qa
attributes.Description of the change
This fix removes the nunjucks whitespace stripping before each custom attribute.
Possible drawbacks
If some service's tests have been written to expect this even though it's incorrect HTML.
Release notes
Ensured that custom attributes get a space inserted before each one