Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to bundled modules using Rollup #1149

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

colinrotherham
Copy link
Collaborator

@colinrotherham colinrotherham commented Feb 6, 2025

This PR updates all component JavaScript with:

  1. CommonJS module.exports in source code
  2. Universal Module Definition (UMD) when packaged

We may need to switch esbuild to Rollup as UMD bundle support isn't included out of the box

Part of #1141

@colinrotherham colinrotherham marked this pull request as ready for review February 7, 2025 09:24
@colinrotherham colinrotherham requested a review from a team as a code owner February 7, 2025 09:24
@colinrotherham colinrotherham changed the title feat: migrate to bundled modules feat: migrate to bundled modules using Rollup Feb 7, 2025
@@ -1,7 +1,7 @@
/**
* Datepicker config
* Daste picker config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@colinrotherham colinrotherham force-pushed the esbuild branch 3 times, most recently from 64dd2e4 to c3aad34 Compare February 12, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants