Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable PostCSS syntax for Stylelint + fixes #1135

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

colinrotherham
Copy link
Collaborator

This PR enables the postcss-scss and postcss-markdown packages

For example, Stylelint currently logs errors for *.md files it doesn't understand:

CODE_OF_CONDUCT.md
  1:3  ✖  Unknown word  CssSyntaxError

CONTRIBUTING.md
  18:28  ✖  Unclosed string  CssSyntaxError

PULL_REQUEST_TEMPLATE.md
  7:44  ✖  Unclosed bracket  CssSyntaxError

README.md
  1:1  ✖  Unclosed bracket  CssSyntaxError

VERSION.md
  1:1  ✖  Unknown word  CssSyntaxError

docs/accessibility.md
  17:13  ✖  Unclosed bracket  CssSyntaxError

docs/building-blocks.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/cookies.md
  6:195  ✖  Unclosed string  CssSyntaxError

docs/help.md
  17:46  ✖  Unclosed bracket  CssSyntaxError

docs/index.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/standards-and-principles.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/style-guide-updates.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/style-guide.md
  78:116  ✖  Unclosed bracket  CssSyntaxError

docs/using-the-design-system.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/archive/currency-input.md
  14:39  ✖  Unclosed bracket  CssSyntaxError

docs/archive/form-validator.md
  15:127  ✖  Unclosed bracket  CssSyntaxError

docs/archive/index.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/archive/password-reveal.md
  24:89  ✖  Unclosed string  CssSyntaxError

docs/archive/question-pages.md
  13:65  ✖  Unclosed bracket  CssSyntaxError

docs/archive/rich-text-editor.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/archive/tag.md
  12:93  ✖  Unclosed bracket  CssSyntaxError

docs/archive/task-list.md
  13:45  ✖  Unclosed bracket  CssSyntaxError

docs/components/add-another.md
  39:245  ✖  Unclosed bracket  CssSyntaxError

docs/components/badge.md
  13:20  ✖  Unclosed bracket  CssSyntaxError

docs/components/banner.md
  13:36  ✖  Unclosed bracket  CssSyntaxError

docs/components/button-menu.md
  26:84  ✖  Unclosed bracket  CssSyntaxError

docs/components/date-picker.md
  40:54  ✖  Unclosed bracket  CssSyntaxError

docs/components/filter.md
  35:43  ✖  Unclosed bracket  CssSyntaxError

docs/components/header.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/components/identity-bar.md
  28:6  ✖  Unclosed string  CssSyntaxError

docs/components/index.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/components/interruption-card.md
  103:56  ✖  Unclosed string  CssSyntaxError

docs/components/messages.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/components/multi-file-upload.md
  61:89  ✖  Unclosed bracket  CssSyntaxError

docs/components/multi-select.md
  20:28  ✖  Unclosed bracket  CssSyntaxError

docs/components/notification-badge.md
  13:21  ✖  Unclosed bracket  CssSyntaxError

docs/components/organisation-switcher.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/components/page-header-actions.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/components/pagination.md
  13:27  ✖  Unclosed bracket  CssSyntaxError

docs/components/primary-navigation.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/components/scrollable-pane.md
  22:123  ✖  Unclosed string  CssSyntaxError

docs/components/search.md
  20:128  ✖  Unclosed string  CssSyntaxError

docs/components/side-navigation.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/components/sortable-table.md
  22:28  ✖  Unclosed bracket  CssSyntaxError

docs/components/sub-navigation.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/components/ticket-panel.md
  28:89  ✖  Unclosed bracket  CssSyntaxError

docs/components/timeline.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/contributing/application-architecture.md
  5:12  ✖  Unclosed bracket  CssSyntaxError

docs/ethics/assessment.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/ethics/design-ethical-services.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/ethics/index.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/ethics/principles.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/ethics/review.md
  21:51  ✖  Unclosed string  CssSyntaxError

docs/get-involved/contribute.md
  23:150  ✖  Unclosed bracket  CssSyntaxError

docs/get-involved/criteria.md
  21:116  ✖  Unclosed string  CssSyntaxError

docs/get-involved/index.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/get-involved/suggest-a-change.md
  19:27  ✖  Unclosed string  CssSyntaxError

docs/pages/case-list.md
  78:18  ✖  Unclosed string  CssSyntaxError

docs/pages/index.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/patterns/add-to-a-list.md
  13:16  ✖  Unclosed bracket  CssSyntaxError

docs/patterns/filter-a-list.md
  26:27  ✖  Unclosed string  CssSyntaxError

docs/patterns/get-help.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/patterns/index.md
  10:159  ✖  Unclosed string  CssSyntaxError

docs/patterns/upload-files.md
  39:60  ✖  Unclosed bracket  CssSyntaxError

docs/production/index.md
  2:1  ✖  Unknown word  CssSyntaxError

docs/production/install-moj-frontend.md
  17:79  ✖  Unclosed bracket  CssSyntaxError

docs/production/installing-compiled.md
  24:108  ✖  Unclosed bracket  CssSyntaxError

docs/production/installing-with-npm.md
  17:60  ✖  Unclosed bracket  CssSyntaxError

docs/production/setting-up-javascript.md
  64:41  ✖  Unclosed string  CssSyntaxError

docs/prototyping/deploying-coded-prototypes.md
  15:27  ✖  Unclosed bracket  CssSyntaxError

docs/prototyping/index.md
  2:3  ✖  Unknown word  CssSyntaxError

docs/prototyping/setting-up-coded-prototypes.md
  17:46  ✖  Unclosed bracket  CssSyntaxError

docs/prototyping/setting-up-figma-prototypes.md
  22:21  ✖  Unclosed bracket  CssSyntaxError

docs/service-patterns/apply.md
  33:53  ✖  Unclosed bracket  CssSyntaxError

docs/service-patterns/index.md
  45:70  ✖  Unclosed string  CssSyntaxError

docs/_includes/arguments/badge.md
  9:163  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/button-menu.md
  18:27  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/currency-input.md
  62:163  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/date-picker.md
  6:151  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/header.md
  36:163  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/interruption-card.md
  15:103  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/messages.md
  20:163  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/pagination.md
  1:1  ✖  Unknown word  CssSyntaxError

docs/_includes/arguments/primary-navigation.md
  22:163  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/side-navigation.md
  38:163  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/sub-navigation.md
  20:163  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/task-list.md
  37:163  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/ticket-panel.md
  17:163  ✖  Unclosed bracket  CssSyntaxError

docs/_includes/arguments/timeline.md
  34:237  ✖  Unclosed bracket  CssSyntaxError

docs/assets/stylesheets/components/_accordions.scss
  16:19  ✖  Unexpected !important  declaration-no-important
  25:30  ✖  Unexpected !important  declaration-no-important

src/moj/components/action-bar/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/add-another/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/badge/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/banner/README.md
  1:1  ✖  Unexpected empty source  no-empty-source

src/moj/components/button-menu/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/cookie-banner/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/date-picker/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/currency-input/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/filter/README.md
  1:1  ✖  Unknown word  CssSyntaxError

src/moj/components/filter-toggle-button/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/form-validator/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/header/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/identity-bar/README.md
  1:1  ✖  Unexpected empty source  no-empty-source

src/moj/components/messages/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/multi-file-upload/README.md
  1:1  ✖  Unknown word  CssSyntaxError

src/moj/components/multi-select/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/notification-badge/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/page-header-actions/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/organisation-switcher/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/pagination/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/password-reveal/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/primary-navigation/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/progress-bar/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/rich-text-editor/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/search/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/search-toggle/README.md
  1:1  ✖  Unknown word  CssSyntaxError

src/moj/components/side-navigation/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/sortable-table/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/sub-navigation/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/tag/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/task-list/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/ticket-panel/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

src/moj/components/timeline/README.md
  3:13  ✖  Unclosed bracket  CssSyntaxError

✖ 124 problems (124 errors, 0 warnings)

@colinrotherham colinrotherham requested a review from a team as a code owner January 31, 2025 16:54
Comment on lines 11 to 16
.govuk-accordion__show-all:hover {
// stylelint-disable-next-line declaration-no-important
background: #ebebeb !important;
// stylelint-disable-next-line declaration-no-important
box-shadow:
0 -2px #ebebeb,
0 4px #ebebeb !important;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier multi-line formatting made // stylelint-disable-next-line target the wrong line

@colinrotherham colinrotherham merged commit 9d3edc1 into main Feb 3, 2025
22 checks passed
@colinrotherham colinrotherham deleted the stylelint-fixes branch February 3, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants