Add stylelint config and lint all scss files #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we want to follow the no important rule, so we want it enabled for all new css. But as correcting the existing instances will require some work to resolve, we will simply disable the rule for each use.
chrispymm
force-pushed
the
add-stylelint
branch
from
c9533fd to
6d86ef1
Compare
chrispymm
force-pushed
the
add-stylelint
branch
from
6d86ef1 to
d001692
Compare
jbarnardmoj
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds stylelint and configures it to GDS conventions
All scss files have been linted and fixed, except where a fix would affect specificity. In those instances, the stylelint rule has been diasbled.
A future task will be to go through the
stylelint-disablecomments and see if they can be resolved without breaking the component.