Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multi file upload example #1094

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

chrispymm
Copy link
Contributor

This PR fixes an issue in the multi file upload example with the uploaded files area showing on load.

The main improvement however is to use the xhook library to intercept the ajax upload events and provide dummy upload progress and responses in order to demonstrate the full use of the component.

The xhook library is conditionally included in the page when required, and a supporting js file can also be included on example pages too.

…nses

This commit uses the xhook library to intercept the ajax requests for the multi file upload
component and return spoof responses so that users can see how the component functions  in use.
@chrispymm chrispymm requested a review from a team as a code owner January 21, 2025 12:31
@chrispymm chrispymm added the preview:request Deploy PR to a preview url label Jan 21, 2025
Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-improve-multi-file-upload-example.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

@github-actions github-actions bot added preview:active and removed preview:request Deploy PR to a preview url labels Jan 21, 2025
if a single file is dropped after 3 files have been picked and uploaded som
Not sure how it actually worked before, but it works better and more consistently now!
Copy link

🚀 Deployed to preview environment! If this is the first deploy, you may have to wait a few minutes for your preview site to be ready on the following URL:

https://moj-frontend-improve-multi-file-upload-example.apps.live.cloud-platform.service.justice.gov.uk

Username: preview, Password: moj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants