fix(package): Rename compiled js with jquery #1029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adjusts the build:package task to also output a compiled minified js and css file. It also fixes the compiled output including jQuery, which didn't work due to jQuery ending up bundled by the umd
…nsistency This PR simply renames the compiled js file that includes jquery from 'all.jquery.min.js' to 'moj-frontend.jquery.min.js' for consistency with the other compiled files. BREAKING CHANGE: The compiled javscript output with bundled jQuery has been reanmed from 'all.jquery.min.js' to 'moj-frontend.jquery.min.js'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply renames the compiled js file that includes jquery from 'all.jquery.min.js' to
'moj-frontend.jquery.min.js' for consistency with the other compiled files.
Fixes #1030
BREAKING CHANGE: The compiled javscript output with bundled jQuery has been renamed from
all.jquery.min.jstomoj-frontend.jquery.min.js.