Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version of remote baselines repo. - DO NOT MERGE #9146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikereiddigital
Copy link
Contributor

A reference to the issue / Description of it

{Please write here}

How does this PR fix the problem?

{Please write here}

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/bootstrap/secure-baselines


Running Trivy in terraform/environments/bootstrap/secure-baselines
2025-01-31T12:50:41Z INFO [vulndb] Need to update DB
2025-01-31T12:50:41Z INFO [vulndb] Downloading vulnerability DB...
2025-01-31T12:50:41Z INFO [vulndb] Downloading artifact... repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-31T12:50:43Z INFO [vulndb] Artifact successfully downloaded repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-31T12:50:43Z INFO [vuln] Vulnerability scanning is enabled
2025-01-31T12:50:43Z INFO [misconfig] Misconfiguration scanning is enabled
2025-01-31T12:50:43Z INFO [misconfig] Need to update the built-in checks
2025-01-31T12:50:43Z INFO [misconfig] Downloading the built-in checks...
162.46 KiB / 162.46 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2025-01-31T12:50:43Z INFO [secret] Secret scanning is enabled
2025-01-31T12:50:43Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-31T12:50:43Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-31T12:50:44Z INFO [terraform scanner] Scanning root module file_path="."
2025-01-31T12:50:46Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z INFO [terraform executor] Ignore finding rule="aws-s3-encryption-customer-key" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf:157-165"
2025-01-31T12:50:46Z INFO Number of language-specific files num=0
2025-01-31T12:50:46Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/secure-baselines

*****************************

Running Checkov in terraform/environments/bootstrap/secure-baselines
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2025-01-31 12:50:48,598 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 11, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/environments/bootstrap/secure-baselines

*****************************

Running tflint in terraform/environments/bootstrap/secure-baselines
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/bootstrap/secure-baselines

*****************************

Running Trivy in terraform/environments/bootstrap/secure-baselines
2025-01-31T12:50:41Z	INFO	[vulndb] Need to update DB
2025-01-31T12:50:41Z	INFO	[vulndb] Downloading vulnerability DB...
2025-01-31T12:50:41Z	INFO	[vulndb] Downloading artifact...	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-31T12:50:43Z	INFO	[vulndb] Artifact successfully downloaded	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-31T12:50:43Z	INFO	[vuln] Vulnerability scanning is enabled
2025-01-31T12:50:43Z	INFO	[misconfig] Misconfiguration scanning is enabled
2025-01-31T12:50:43Z	INFO	[misconfig] Need to update the built-in checks
2025-01-31T12:50:43Z	INFO	[misconfig] Downloading the built-in checks...
162.46 KiB / 162.46 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2025-01-31T12:50:43Z	INFO	[secret] Secret scanning is enabled
2025-01-31T12:50:43Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-31T12:50:43Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-31T12:50:44Z	INFO	[terraform scanner] Scanning root module	file_path="."
2025-01-31T12:50:46Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/modules/config/main.tf:40"
2025-01-31T12:50:46Z	INFO	[terraform executor] Ignore finding	rule="aws-s3-encryption-customer-key" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dffd77b42e10a2f78b514cf379015cf3121e8030/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf:157-165"
2025-01-31T12:50:46Z	INFO	Number of language-specific files	num=0
2025-01-31T12:50:46Z	INFO	Detected config files	num=3
trivy_exitcode=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant