Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions repository for the Modernisation Platform #8944

Merged

Conversation

sukeshreddyg
Copy link
Contributor

@sukeshreddyg sukeshreddyg commented Jan 14, 2025

A reference to the issue / Description of it

This PR introduces a new repository for GitHub Actions related to the Modernisation Platform. These actions are designed to streamline and enhance workflows across projects within the platform. #7109

How does this PR fix the problem?

Adds the repository

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/github


Running Trivy in terraform/github
2025-01-14T13:35:51Z INFO [vulndb] Need to update DB
2025-01-14T13:35:51Z INFO [vulndb] Downloading vulnerability DB...
2025-01-14T13:35:51Z INFO [vulndb] Downloading artifact... repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-14T13:35:54Z INFO [vulndb] Artifact successfully downloaded repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-14T13:35:54Z INFO [vuln] Vulnerability scanning is enabled
2025-01-14T13:35:54Z INFO [misconfig] Misconfiguration scanning is enabled
2025-01-14T13:35:54Z INFO [misconfig] Need to update the built-in checks
2025-01-14T13:35:54Z INFO [misconfig] Downloading the built-in checks...
160.80 KiB / 160.80 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2025-01-14T13:35:54Z INFO [secret] Secret scanning is enabled
2025-01-14T13:35:54Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-14T13:35:54Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-14T13:35:55Z INFO [terraform scanner] Scanning root module file_path="."
2025-01-14T13:35:55Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="github_token"
2025-01-14T13:35:55Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.contributor-access" value="cty.NilVal"
2025-01-14T13:35:56Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.modernisation-platform-environments.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:56Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.modernisation-platform-instance-scheduler.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:56Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.modernisation-platform-terraform-aws-chatbot.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.modernisation-platform-terraform-aws-data-firehose.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.modernisation-platform-terraform-dns-certificates.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.modernisation-platform-terraform-member-vpc.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.modernisation-platform-terraform-module-template.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.modernisation-platform-terraform-pagerduty-integration.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="testing-ci.tf:4-9"
2025-01-14T13:35:57Z INFO Number of language-specific files num=0
2025-01-14T13:35:57Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/github

*****************************

Running Checkov in terraform/github
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 99, Failed checks: 0, Skipped checks: 107


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/github

*****************************

Running tflint in terraform/github
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/github

*****************************

Running Trivy in terraform/github
2025-01-14T13:35:51Z	INFO	[vulndb] Need to update DB
2025-01-14T13:35:51Z	INFO	[vulndb] Downloading vulnerability DB...
2025-01-14T13:35:51Z	INFO	[vulndb] Downloading artifact...	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-14T13:35:54Z	INFO	[vulndb] Artifact successfully downloaded	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-14T13:35:54Z	INFO	[vuln] Vulnerability scanning is enabled
2025-01-14T13:35:54Z	INFO	[misconfig] Misconfiguration scanning is enabled
2025-01-14T13:35:54Z	INFO	[misconfig] Need to update the built-in checks
2025-01-14T13:35:54Z	INFO	[misconfig] Downloading the built-in checks...
160.80 KiB / 160.80 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2025-01-14T13:35:54Z	INFO	[secret] Secret scanning is enabled
2025-01-14T13:35:54Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-14T13:35:54Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-14T13:35:55Z	INFO	[terraform scanner] Scanning root module	file_path="."
2025-01-14T13:35:55Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="github_token"
2025-01-14T13:35:55Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.contributor-access" value="cty.NilVal"
2025-01-14T13:35:56Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.modernisation-platform-environments.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:56Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.modernisation-platform-instance-scheduler.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:56Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.modernisation-platform-terraform-aws-chatbot.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.modernisation-platform-terraform-aws-data-firehose.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.modernisation-platform-terraform-dns-certificates.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.modernisation-platform-terraform-member-vpc.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.modernisation-platform-terraform-module-template.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.modernisation-platform-terraform-pagerduty-integration.github_actions_secret.default" value="cty.NilVal"
2025-01-14T13:35:57Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="testing-ci.tf:4-9"
2025-01-14T13:35:57Z	INFO	Number of language-specific files	num=0
2025-01-14T13:35:57Z	INFO	Detected config files	num=3
trivy_exitcode=0

Copy link
Contributor

Terraform Plan Summary

github
Plan: 4 to add, 0 to change, 0 to destroy.

@sukeshreddyg sukeshreddyg marked this pull request as ready for review January 14, 2025 13:43
@sukeshreddyg sukeshreddyg requested a review from a team as a code owner January 14, 2025 13:43
Copy link
Contributor

@mikereiddigital mikereiddigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@sukeshreddyg sukeshreddyg added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit b8edcce Jan 14, 2025
6 checks passed
@sukeshreddyg sukeshreddyg deleted the feature/create-modernisation-platform-github-actions branch January 14, 2025 13:46
Copy link
Contributor

Terraform Plan Summary

github
Plan: 62 to add, 1 to change, 0 to destroy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants