Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dacp.json #8932

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Update dacp.json #8932

merged 1 commit into from
Jan 13, 2025

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Jan 13, 2025

Updated in line with @mark-butler-solirius 's comments

A reference to the issue / Description of it

#8823

How does this PR fix the problem?

Updates details

How has this been tested?

Tested through CI pipeline

Deployment Plan / Instructions

Deployment will trigger update to tags which may lead to a recreation of some resources.

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

Updated in line with @mark-butler-solirius 's comments
@dms1981 dms1981 requested a review from a team as a code owner January 13, 2025 11:25
@github-actions github-actions bot added the onboarding Tasks to onboard teams label Jan 13, 2025
Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

Terraform Plan Summary

github
No changes. Your infrastructure matches the configuration.

Copy link
Contributor

@richgreen-moj richgreen-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dms1981 dms1981 added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit d8fe052 Jan 13, 2025
16 checks passed
@dms1981 dms1981 deleted the dms1981-patch-1 branch January 13, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants