Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MoJRedTeam and granttvm-purple-team access to cooker #8864

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

richgreen-moj
Copy link
Contributor

A reference to the issue / Description of it

As requested in the ask channel here: https://mojdt.slack.com/archives/C01A7QK5VM1/p1736171196013009

And after the requirement was refined in a private group chat here: https://moj.enterprise.slack.com/archives/C087EKMGXLK

How does this PR fix the problem?

  1. Removes MoJRedTeam acceess from cooker as they no longer require it.

  2. Grantstvm-purple-team access to cooker as agreed

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@richgreen-moj richgreen-moj requested a review from a team as a code owner January 6, 2025 15:33
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

@github-actions github-actions bot added the onboarding Tasks to onboard teams label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Terraform Plan Summary

github
Plan: 27 to add, 0 to change, 0 to destroy.

@richgreen-moj richgreen-moj added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit a98da90 Jan 6, 2025
16 checks passed
@richgreen-moj richgreen-moj deleted the tvm-access-request branch January 6, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants