Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding check for no issue number #8792

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

adding check for no issue number #8792

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d31d58f
adding check for no issue number
markgov Dec 19, 2024
ed57fe0
added another check to validate the if statment
markgov Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/reusable_terraform_plan_apply.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ jobs:
const identifier = workflowId ? `_${workflowId}_\n` : `_${{ inputs.workflow_id }}_\n`;
const summary = `\`${{ steps.show.outputs.summary }}\``;
const issue_number = context.payload.pull_request.number;
if (!issue_number) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this can work. You are comparing null to boolean and I cannot see the evidence of it working, as this run has a PR number.

console.log('No issue number found, skipping comment.');
return;
}
await github.rest.issues.createComment({
...context.repo,
issue_number,
Expand Down
Loading