Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change analytical-platform-compute-common to member account type #8773

Merged

Conversation

richgreen-moj
Copy link
Contributor

@richgreen-moj richgreen-moj commented Dec 16, 2024

A reference to the issue / Description of it

After speaking to @jacobwoffenden we're changing this account type to member as it should create the necessary files to create infra/pipelines in the modrnisation-platform-environments repository.

Also there wasn't a real need for the account to be unrestricted.

How does this PR fix the problem?

Changes account type.

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@richgreen-moj richgreen-moj requested a review from a team as a code owner December 16, 2024 11:50
@github-actions github-actions bot added the onboarding Tasks to onboard teams label Dec 16, 2024
Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@richgreen-moj richgreen-moj added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit b3002ed Dec 16, 2024
27 checks passed
@richgreen-moj richgreen-moj deleted the feature/8621-change-AP-compute-common-account-setup branch December 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants