Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collaborators for youth-justice-app-framework #8755

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Dec 12, 2024

A reference to the issue / Description of it

#8706

How does this PR fix the problem?

Adds external collaborators for YJAF

How has this been tested?

Standard process

Deployment Plan / Instructions

CI Pipeline will create users. I will follow user guide afterwards to provision users with credentials

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@dms1981 dms1981 requested a review from a team as a code owner December 12, 2024 17:33
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@dms1981 dms1981 marked this pull request as draft December 13, 2024 07:59
@dms1981
Copy link
Contributor Author

dms1981 commented Dec 13, 2024

Converted to draft while I check on a potential duplicate collaborator - jason.green.

@dms1981 dms1981 marked this pull request as ready for review December 13, 2024 08:40
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dms1981 dms1981 added this pull request to the merge queue Dec 13, 2024
@dms1981 dms1981 merged commit 5a633cf into main Dec 13, 2024
7 checks passed
@dms1981 dms1981 deleted the feature/8706-yjb-yjaf-collaborators branch December 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants